Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add X-GitHub-SSO to response-headers #663

Merged
merged 1 commit into from Nov 28, 2017

Conversation

armw4
Copy link

@armw4 armw4 commented Nov 28, 2017

No description provided.

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers :)

@gr2m gr2m merged commit 1e07daf into octokit:master Nov 28, 2017
@armw4
Copy link
Author

armw4 commented Nov 28, 2017

Awesome! Thanks you kindly, good sir (@gr2m). 👍

@armw4 armw4 deleted the whitelist-github-sso-header branch November 28, 2017 01:16
@armw4
Copy link
Author

armw4 commented Nov 28, 2017

@jameslfc
Copy link

@armw4 I was reading the article you attached above.. What does the statement below actually means?
"Visit the URL specified in X-GitHub-SSO to whitelist the token for the organization."

I was trying to connect to my organization repository with sourcetree.. but I couldn't get it work.. Guess I might not whitelisting my repository correctly..

@armw4
Copy link
Author

armw4 commented Oct 21, 2019

Hmm...it’s been a while since I dealt with this. I recall needling to interrogate the aforementioned response header inside my express.js app to determine if SSO was enabled for an organization. I believe I tenderer an error message of sorts to warn the user they needed to use a token which encapsulates the SSO authorization as opposed to Basic Auth. The token takes SSO into account and is more restrictive as opposed to all encompassing and permissive like Basic Auth (you have to explicitly grant org access, repository access, etc.).

@armw4
Copy link
Author

armw4 commented Oct 21, 2019

Yes! I found it. You need to use a Personal Access Token to access web resources when SSO is enabled. It allows the admin to track your access and tokens (great for Enterprise-Grade organizations). I encountered this while building an Atlassian Connect Express Jira Cloud add-on.

@jameslfc
Copy link

@armw4 Thank you so much for responding so quick, and spending time on researching this
Unfortunately I wan't get Sourcetree work even with the Personal Access Token.. I changed to use GitKraken, and it seems much easier to setup ...
But thanks again ((I hope I can offer you a beer)...

@armw4
Copy link
Author

armw4 commented Oct 21, 2019

Haha..no problem sir have a great 21st of October, 2019 ⭐️ 🌍 ☮️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants