Fix: Mark qualified name type annotations as used (#88)

bradzacher · Nov 23, 2017 · 29bd53c · 29bd53c
1 parent 5e3999d
commit 29bd53c
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/lib/rules/no-unused-vars.js b/lib/rules/no-unused-vars.js
@@ -69,15 +69,26 @@ module.exports = {
             const annotation = node.typeAnnotation || node;
 
             switch (annotation.type) {
+                case "Identifier": {
+                    markVariableAsUsed(context, annotation.name);
+                    break;
+                }
                 case "TSArrayType": {
                     markTypeAnnotationAsUsed(annotation.elementType);
                     break;
                 }
+                case "TSQualifiedName": {
+                    markTypeAnnotationAsUsed(annotation.left);
+                    markTypeAnnotationAsUsed(annotation.right);
+                    break;
+                }
                 case "TSTypeReference": {
                     if (annotation.typeName.type === "TSArrayType") {
                         markTypeAnnotationAsUsed(
                             annotation.typeName.elementType
                         );
+                    } else if (annotation.typeName.type === "TSQualifiedName") {
+                        markTypeAnnotationAsUsed(annotation.typeName);
                     } else {
                         markVariableAsUsed(context, annotation.typeName.name);
                         if (

diff --git a/tests/lib/rules/no-unused-vars.js b/tests/lib/rules/no-unused-vars.js
@@ -434,6 +434,22 @@ ruleTester.run("no-unused-vars", ruleNoUnusedVars, {
                 "}"
             ].join("\n"),
             parser
+        },
+        {
+            code: [
+                "import Foo from 'foo'",
+                "const bar: Foo.Bar = null",
+                "console.log(bar)"
+            ].join("\n"),
+            parser
+        },
+        {
+            code: [
+                "import Foo from 'foo'",
+                "const baz: Foo.Bar.Baz = null",
+                "console.log(baz)"
+            ].join("\n"),
+            parser
         }
     ],