Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: revert to corejs@2 #5317

Merged
merged 2 commits into from
Mar 21, 2019
Merged

hotfix: revert to corejs@2 #5317

merged 2 commits into from
Mar 21, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 21, 2019

Revert core-js to v2 as it is the default for current babel and forcing to v3 causes issues like #5313. Upgrading is also a breaking change for projects that have a babel.config file. So it makes sense to do it for nuxt3 or when ecosystem adopted more to v3.

@pi0 pi0 requested review from clarkdo and a team March 21, 2019 19:09
@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #5317 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5317   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          74       74           
  Lines        2513     2513           
  Branches      639      639           
=======================================
  Hits         2404     2404           
  Misses         92       92           
  Partials       17       17
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 95.5% <ø> (ø) ⬆️
packages/babel-preset-app/src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67b298...7616148. Read the comment docs.

@clarkdo
Copy link
Member

clarkdo commented Mar 21, 2019

LGTM

@clarkdo
Copy link
Member

clarkdo commented Mar 21, 2019

One thing need to be noticed, if any lib has already updated to core-js 3, this is still an issue.

So it would be better to provide a way to detect or manually config corejs version, I'll work on it, for now let's revert and release this pr as hotfix.

@clarkdo clarkdo changed the base branch from dev to 2.x March 21, 2019 19:24
@clarkdo clarkdo merged commit 20836d9 into 2.x Mar 21, 2019
@pi0 pi0 deleted the hotfix/core-js branch March 21, 2019 19:48
@simllll
Copy link

simllll commented Mar 28, 2019

just ran into this issue, we adopted already everything to core js 3.. actually I was just waiting for 2.5 to come because of core js 3. Any other idea how we could solve this?

@pi0
Copy link
Member Author

pi0 commented Mar 28, 2019

@simllll sorry to hear that :( Actually we've faced lots of problems because of libs that implicitly depend on corejs 2 and we can't support both at a same time. How did you get prepared for 3.x?

@simllll
Copy link

simllll commented Mar 28, 2019

Yeah we had similar troubles, but switched or patched some libraries to get over it. Wasn't that much effort in the end for us, but still not so cool if we would revert this now.

I just read clarkdos comment that he is working on a option/flag to set the core is version, this would solve our problem! So I just fixed our version to 2.5.0 for now.

@pi0
Copy link
Member Author

pi0 commented Mar 29, 2019

@simllll You requested and it will be possible with next version (2.6.0) via #5411. All thanks to @clarkdo ❤️

@simllll
Copy link

simllll commented Mar 29, 2019

Very nice :) thanks guys for this awesome project!

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants