Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builder): allow to customize or disable minimizer plugins #4018

Merged
merged 3 commits into from Sep 30, 2018

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 30, 2018

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Background: CSSNano is currently applied twice. Once with PostCSS loader and once with optimizeCSSAssetsPlugin. This is normally not harmful and good indeed but for incompatible CSS assets like Framework7 is problematic and currently there is not any way to disable or customize options.

This enhancement allows toggling or providing more options to both terser and optimizeCSS plugins. Also adds support for setting false value to minimize to disable them at all (for testing purposes and more webpack options compatibility)

Checklist:

@pi0 pi0 requested review from manniL and clarkdo September 30, 2018 11:19
@codecov-io
Copy link

codecov-io commented Sep 30, 2018

Codecov Report

Merging #4018 into dev will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4018      +/-   ##
==========================================
- Coverage   97.56%   97.49%   -0.08%     
==========================================
  Files          18       18              
  Lines        1233     1236       +3     
  Branches      337      341       +4     
==========================================
+ Hits         1203     1205       +2     
- Misses         29       30       +1     
  Partials        1        1
Impacted Files Coverage Δ
lib/common/nuxt.config.js 100% <ø> (ø) ⬆️
lib/common/options.js 97.08% <100%> (+0.11%) ⬆️
lib/builder/webpack/client.js 96.77% <100%> (-0.11%) ⬇️
lib/core/nuxt.js 94.16% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf6385...cd11762. Read the comment docs.

@Atinux Atinux merged commit 8f06a18 into dev Sep 30, 2018
@Atinux Atinux deleted the feat/customize-minimizer branch September 30, 2018 16:09
@manniL manniL mentioned this pull request Oct 16, 2018
3 tasks
@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants