Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typofixes - https://github.com/vlajos/misspell-fixer #4013

Merged
merged 1 commit into from Sep 29, 2018

Conversation

vlajos
Copy link

@vlajos vlajos commented Sep 29, 2018

Some random typo fixes in examples and comments.

Types of changes

  • Typofixes

Description

Some random typo fixes in examples and comments.
Found by https://github.com/vlajos/misspell-fixer

@vlajos vlajos changed the title * Typofixes - https://github.com/vlajos/misspell-fixer Typofixes - https://github.com/vlajos/misspell-fixer Sep 29, 2018
@codecov-io
Copy link

codecov-io commented Sep 29, 2018

Codecov Report

Merging #4013 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4013   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          18       18           
  Lines        1233     1233           
  Branches      337      337           
=======================================
  Hits         1203     1203           
  Misses         29       29           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1d94a...1dfddd1. Read the comment docs.

@@ -82,7 +82,7 @@ export default {
if (worker) worker.postMessage({ hello: 'world' })
else this.notification = 'No more test workers available'
},
long (miliseconds) {
long (milliseconds) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol why are there spaces after method names?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, can be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint @qm3ster

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps, I need more sleeping now 🤕

@@ -29,7 +29,7 @@ export interface Person {
gender: string
ip_address: string
avatar: string
addres: PersonAddress
address: PersonAddress
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy how this didn't break anything, because this is never actually displayed in the card component or anything.

@Atinux Atinux merged commit 74eb5a6 into nuxt:dev Sep 29, 2018
@vlajos vlajos deleted the misspell-fixer-20180929 branch October 19, 2018 12:30
@lock
Copy link

lock bot commented Nov 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 18, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants