fix(cli): apply default value for NODE_ENV environment variable

[pi0]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Related to #4002. Some tools (Including the current version of vue-loader) implicitly use process.env.NODE_ENV to align their options. This change only sets the best value for NODE_ENV if not already set so it won't break anything.

• The reason for including before any require() is that some modules may need this env during evaluation.
• The reason for not refactoring this logic inside bin/nuxt is binaries portability. (nuxt-start directly is being called)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests pass.

[codecov-io]

Codecov Report

Merging #4003 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #4003   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          18       18           
  Lines        1233     1233           
  Branches      337      337           
=======================================
  Hits         1203     1203           
  Misses         29       29           
  Partials        1        1

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7fa66d...eb0b714. Read the comment docs.

[manniL]

Related (though closed already): #2998

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.