Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/2] expose loading.throttle as an option #3953

Merged
merged 2 commits into from Sep 24, 2018
Merged

Conversation

ishitatsuyuki
Copy link

Types of changes

Fix unintended behavior from the previous PR

Description

This is the minimal subset of #3891.

Checklist:

@codecov-io
Copy link

codecov-io commented Sep 24, 2018

Codecov Report

Merging #3953 into dev will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3953      +/-   ##
==========================================
- Coverage   97.56%   97.48%   -0.09%     
==========================================
  Files          18       18              
  Lines        1232     1232              
  Branches      337      337              
==========================================
- Hits         1202     1201       -1     
- Misses         29       30       +1     
  Partials        1        1
Impacted Files Coverage Δ
lib/common/nuxt.config.js 100% <ø> (ø) ⬆️
lib/core/nuxt.js 94.16% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054ea79...b28f158. Read the comment docs.

Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarkdo clarkdo merged commit 55a153c into nuxt:dev Sep 24, 2018
@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants