Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use options.server values port, host, socket #3942

Merged
merged 2 commits into from Sep 23, 2018

Conversation

aldarund
Copy link

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves : #3941

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests passed.

@Atinux
Copy link
Member

Atinux commented Sep 22, 2018

Thank you @aldarund, waiting for CI to merge

@codecov-io
Copy link

codecov-io commented Sep 22, 2018

Codecov Report

Merging #3942 into dev will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3942      +/-   ##
==========================================
+ Coverage   97.48%   97.56%   +0.08%     
==========================================
  Files          18       18              
  Lines        1232     1232              
  Branches      335      337       +2     
==========================================
+ Hits         1201     1202       +1     
+ Misses         30       29       -1     
  Partials        1        1
Impacted Files Coverage Δ
lib/core/nuxt.js 95% <100%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a68e1d...e52196c. Read the comment docs.

lib/core/nuxt.js Outdated Show resolved Hide resolved
@Atinux Atinux merged commit 9c3702c into nuxt:dev Sep 23, 2018
@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

host and port is not able to configure from nuxt.config.json
6 participants