feat: use understandable file names for analyze mode (#4014)

* feat: use understandable file names for analyze mode * test: asset name for analyze mode * refactor: add warning message for analyze mode * refactor: move analyze warning to builder * test: analyze warning message
nuxt · Sep 30, 2018 · 0393bf7 · 0393bf7
1 parent 8f06a18
commit 0393bf7
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 6 deletions.
diff --git a/lib/builder/builder.js b/lib/builder/builder.js
@@ -59,6 +59,15 @@ export default class Builder {
       this.mfs = new MFS()
     }
 
+    if (this.options.build.analyze) {
+      this.nuxt.hook('build:done', () => {
+        consola.warn({
+          message: 'Notice: Please do not deploy bundles built with analyze mode, it\'s only for analyzing purpose.',
+          badge: true
+        })
+      })
+    }
+
     // if(!this.options.dev) {
     // TODO: enable again when unsafe concern resolved.(common/options.js:42)
     // this.nuxt.hook('build:done', () => this.generateConfig())

diff --git a/lib/builder/webpack/client.js b/lib/builder/webpack/client.js
@@ -15,6 +15,16 @@ export default class WebpackClientConfig extends WebpackBaseConfig {
     super(builder, { name: 'client', isServer: false })
   }
 
+  getFileName(...args) {
+    if (this.options.build.analyze) {
+      const key = args[0]
+      if (['app', 'chunk'].includes(key)) {
+        return '[name].js'
+      }
+    }
+    return super.getFileName(...args)
+  }
+
   env() {
     return Object.assign(super.env(), {
       'process.env.VUE_ENV': JSON.stringify('client'),

diff --git a/test/fixtures/with-config/with-config.test.js b/test/fixtures/with-config/with-config.test.js
@@ -14,13 +14,19 @@ const hooks = [
 
 describe('with-config', () => {
   buildFixture('with-config', () => {
-    expect(consola.warn).toHaveBeenCalledTimes(1)
+    expect(consola.warn).toHaveBeenCalledTimes(2)
     expect(consola.fatal).toHaveBeenCalledTimes(0)
-    expect(consola.warn.mock.calls[0]).toMatchObject([{
-      message: 'Found 2 plugins that match the configuration, suggest to specify extension:',
-      additional: expect.stringContaining('plugins/test.json'),
-      badge: true
-    }])
+    expect(consola.warn.mock.calls).toMatchObject([
+      [{
+        message: 'Found 2 plugins that match the configuration, suggest to specify extension:',
+        additional: expect.stringContaining('plugins/test.json'),
+        badge: true
+      }],
+      [{
+        message: 'Notice: Please do not deploy bundles built with analyze mode, it\'s only for analyzing purpose.',
+        badge: true
+      }]
+    ])
     expect(customCompressionMiddlewareFunctionName).toBe('damn')
   }, hooks)
 })

diff --git a/test/unit/with-config.test.js b/test/unit/with-config.test.js
@@ -19,6 +19,11 @@ describe('with-config', () => {
     expect(html.includes('<h1>I have custom configurations</h1>')).toBe(true)
   })
 
+  test('/ (asset name for analyze mode)', async () => {
+    const { html } = await nuxt.renderRoute('/')
+    expect(html).toContain('<script src="/test/orion/app.js"')
+  })
+
   test.skip('/ (global styles inlined)', async () => {
     const { html } = await nuxt.renderRoute('/')
     expect(html).toContain('.global-css-selector')