Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process-nextick-args used incorrectly #323

Closed
kolodny opened this issue Mar 2, 2018 · 2 comments
Closed

process-nextick-args used incorrectly #323

kolodny opened this issue Mar 2, 2018 · 2 comments

Comments

@kolodny
Copy link
Contributor

kolodny commented Mar 2, 2018

process-nextick-args was modified to make the nextTick property a "live" binding. In 41a3301#diff-279988bef5e6fbf7ed82cae28ecc2d59L128 this was changed to keep a reference to a potentially stale function. I'm not sure how to go about changing the generated code to make this change, else I would just make a PR.

@mcollina
Copy link
Member

mcollina commented Mar 2, 2018

You need to fix it in this block: https://github.com/nodejs/readable-stream/blob/master/build/files.js#L127-L136.
Then cd build; npm i; node build.js 8.9.4. Should do the trick.

If you could also add a test, it would be awesome. Place it under https://github.com/nodejs/readable-stream/tree/master/test/ours.

@mcollina
Copy link
Member

mcollina commented Mar 3, 2018

Fixed in 2.3.5

@mcollina mcollina closed this as completed Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants