Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include path in the matching log output #996

Merged
merged 1 commit into from Oct 18, 2017
Merged

Conversation

travi
Copy link
Contributor

@travi travi commented Oct 18, 2017

closes #989

i didn't find any tests around log output, so i simply updated the log output. both changes are needed, one for when query params are defined, the other when no query is defined. i verified manually that each fix handles the appropriate case properly after the change.

@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage remained the same at 92.666% when pulling dd44466 on travi:matching-log-path into 6d9704d on node-nock:master.

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍 Cheers @travi

@gr2m gr2m merged commit ea2fe9f into nock:master Oct 18, 2017
@travi travi deleted the matching-log-path branch October 18, 2017 05:12
@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants