Have aborts follow the published API

[allenluce]

I had some difficulty with this code:

httpRequest.on('timeout', function () {
  trackFailure('timeout')
  httpRequest.abort()
})

httpRequest.on('error', function (err) {
  // Count error if request wasn't aborted due to timeout
  if (!httpRequest.aborted) {
    trackFailure(err)
  }
  callback(err)
}

When nock was not in use, trackFailure() would be called once on timeout. With nock enabled, trackFailure() would be called twice because httpRequest.aborted would be undefined.

This change creates and uses the aborted property in the same fashion as the system http module.

[allenluce]

The Travis CI failure doesn't look like it's related to my changes:

npm ERR! Linux 4.4.0-101-generic
npm ERR! argv "/home/travis/.nvm/versions/node/v4.9.1/bin/node" "/home/travis/.nvm/versions/node/v4.9.1/bin/npm" "install"
npm ERR! node v4.9.1
npm ERR! npm  v2.15.11
npm ERR! code EPEERINVALID
npm ERR! peerinvalid The package marked@0.4.0 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer marked-terminal@2.0.0 wants marked@^0.3.6

[allenluce]

I've rebased this on the current master, looks like that took care of the test failures.

[gr2m]

Thanks, looks good 👍

[nockbot]

🎉 This PR is included in version 9.3.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!