Merge pull request #769 from RubenVerborgh/fix-socket-this

Fix this pointer on "socket" event
nock · Feb 9, 2017 · 58b04e3 · 58b04e3
2 parents 1d1cafc + 50859e5
commit 58b04e3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/request_overrider.js b/lib/request_overrider.js
@@ -193,7 +193,7 @@ function RequestOverrider(req, options, interceptors, remove, cb) {
   req.once = req.on = function(event, listener) {
     // emit a fake socket.
     if (event == 'socket') {
-      listener(req.socket);
+      listener.call(req, req.socket);
       req.socket.emit('connect', req.socket);
       req.socket.emit('secureConnect', req.socket);
     }

diff --git a/tests/test_intercept.js b/tests/test_intercept.js
@@ -4212,6 +4212,7 @@ test('request emits socket', function(t) {
 
   var req = http.get('http://gotzsocketz.com');
   req.once('socket', function(socket) {
+    t.equal(this, req);
     t.type(socket, Object);
     t.type(socket.getPeerCertificate(), 'string');
     t.end();