added noop method unref to Socket
#1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it has been implemented in node.js 0.9.1 but it's seldomly used. ref: https://nodejs.org/api/net.html#net_socket_unref
mastermatt
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
I was going to recommend making it a function that returns the socket, since that's what the real Socket def does for chaining. However, the other three method that use noop are in the same boat and it probably makes more sense to keep them the same. And we can change them all to return the socket if that need ever arises.
I think it's good as is.
paulmelnikow
approved these changes
Jul 9, 2019
|
Thanks @zenlor and @mastermatt! |
|
🎉 This PR is included in version 11.0.0-beta.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
it has been implemented in node.js 0.9.1 but it's seldomly used. ref: https://nodejs.org/api/net.html#net_socket_unref
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
it has been implemented in node.js 0.9.1 but it's seldomly used. ref: https://nodejs.org/api/net.html#net_socket_unref
gr2m
pushed a commit
that referenced
this pull request
Sep 5, 2019
it has been implemented in node.js 0.9.1 but it's seldomly used. ref: https://nodejs.org/api/net.html#net_socket_unref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it has been implemented in node.js 0.9.1 but it's seldomly used.
ref: https://nodejs.org/api/net.html#net_socket_unref
I came across this while mocking tests for a project using apm-nodejs-http-client ^