bug: alias connection to socket. #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ClientRequest.connection` is an alias for `ClientRequest.socket`. https://nodejs.org/api/http.html#http_request_socket https://github.com/nodejs/node/blob/master/lib/_http_client.js#L640-L641 `IncomingMessage.connection` is an alias for `IncomingMessage.socket`. https://github.com/nodejs/node/blob/master/lib/_http_incoming.js#L44-L45
|
Coveralls is complaining because the whole lib lost two executable lines, however, this change actually brings |
mastermatt
force-pushed
the
req-connection
branch
from
d37cf74
to
9940410
Compare
paulmelnikow
approved these changes
Jun 20, 2019
Co-Authored-By: Paul Melnikow <github@paulmelnikow.com>
|
🎉 This PR is included in version 11.0.0-beta.20 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
`ClientRequest.connection` is an alias for `ClientRequest.socket`. https://nodejs.org/api/http.html#http_request_socket https://github.com/nodejs/node/blob/master/lib/_http_client.js#L640-L641 `IncomingMessage.connection` is an alias for `IncomingMessage.socket`. https://github.com/nodejs/node/blob/master/lib/_http_incoming.js#L44-L45 Co-Authored-By: Paul Melnikow <github@paulmelnikow.com>
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
`ClientRequest.connection` is an alias for `ClientRequest.socket`. https://nodejs.org/api/http.html#http_request_socket https://github.com/nodejs/node/blob/master/lib/_http_client.js#L640-L641 `IncomingMessage.connection` is an alias for `IncomingMessage.socket`. https://github.com/nodejs/node/blob/master/lib/_http_incoming.js#L44-L45 Co-Authored-By: Paul Melnikow <github@paulmelnikow.com>
gr2m
pushed a commit
that referenced
this pull request
Sep 5, 2019
`ClientRequest.connection` is an alias for `ClientRequest.socket`. https://nodejs.org/api/http.html#http_request_socket https://github.com/nodejs/node/blob/master/lib/_http_client.js#L640-L641 `IncomingMessage.connection` is an alias for `IncomingMessage.socket`. https://github.com/nodejs/node/blob/master/lib/_http_incoming.js#L44-L45 Co-Authored-By: Paul Melnikow <github@paulmelnikow.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientRequest.connectionis an alias forClientRequest.socket.https://nodejs.org/api/http.html#http_request_socket
https://github.com/nodejs/node/blob/master/lib/_http_client.js#L640-L641
IncomingMessage.connectionis an alias forIncomingMessage.socket.https://github.com/nodejs/node/blob/master/lib/_http_incoming.js#L44-L45
Adding
req.connectionandres.connectionas a basicEventEmitterwas to fix #74 when therequestlib use to inspect the alias. This is not the case anymore.res.connectionwas removed a few years later to improve coverage.