Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Digest (3 February, 2019 - 10 February, 2019) #1447

Closed
weekly-digest bot opened this issue Feb 10, 2019 · 0 comments
Closed

Weekly Digest (3 February, 2019 - 10 February, 2019) #1447

weekly-digest bot opened this issue Feb 10, 2019 · 0 comments

Comments

@weekly-digest
Copy link

weekly-digest bot commented Feb 10, 2019

Here's the Weekly Digest for nock/nock:


ISSUES

Last week 14 issues were created.
Of these, 9 issues have been closed and 5 issues are still open.

OPEN ISSUES

💚 #1446 Nock doesn't reply when data to be sent is false, by mukkachaitanya
💚 #1445 nock not matching (possibly due to special characters?), by ericcarino
💚 #1442 Global flag to enable/disable .log(console.log) statement for all the nocks, by pooja098
💚 #1441 [RFC] on new lifecycle methods, by paulmelnikow
💚 #1440 fix(intercept): Better error message when options is falsy, by paulmelnikow

CLOSED ISSUES

❤️ #1444 Updates from npm audit, by paulmelnikow
❤️ #1443 Update nyc to the latest version 🚀, by greenkeeper[bot]
❤️ #1439 test(interceptor): Cover no 'fs', by paulmelnikow
❤️ #1438 fix(socket): When Socket#setTimeout gets a callback, should still emit, by paulmelnikow
❤️ #1436 fix(define): Throw when define() called without method, improve coverage, and refactor tests, by paulmelnikow
❤️ #1435 refactor(test_recorder): Convert a couple to async; use arrow functions, by paulmelnikow
❤️ #1434 refactor(scope): Remove unreachable code in Scope constructor, by paulmelnikow
❤️ #1433 refactor(match_body): Remove dead code, by paulmelnikow
❤️ #1432 test(interceptor): Cover debug() call in match, by paulmelnikow

LIKED ISSUE

👍 #1441 [RFC] on new lifecycle methods, by paulmelnikow
It received 👍 x1, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

🔈 #1442 Global flag to enable/disable .log(console.log) statement for all the nocks, by pooja098
It received 3 comments.


PULL REQUESTS

Last week, 15 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 4 pull requests were updated.
💛 #1441 [RFC] on new lifecycle methods, by paulmelnikow
💛 #1440 fix(intercept): Better error message when options is falsy, by paulmelnikow
💛 #1429 Discussion: better error messages, by elliotf
💛 #1428 fix(intercept): Add support for node 10.x ClientRequest, by nijynot

MERGED PULL REQUEST

Last week, 11 pull requests were merged.
💜 #1444 Updates from npm audit, by paulmelnikow
💜 #1443 Update nyc to the latest version 🚀, by greenkeeper[bot]
💜 #1439 test(interceptor): Cover no 'fs', by paulmelnikow
💜 #1438 fix(socket): When Socket#setTimeout gets a callback, should still emit, by paulmelnikow
💜 #1436 fix(define): Throw when define() called without method, improve coverage, and refactor tests, by paulmelnikow
💜 #1435 refactor(test_recorder): Convert a couple to async; use arrow functions, by paulmelnikow
💜 #1434 refactor(scope): Remove unreachable code in Scope constructor, by paulmelnikow
💜 #1433 refactor(match_body): Remove dead code, by paulmelnikow
💜 #1432 test(interceptor): Cover debug() call in match, by paulmelnikow
💜 #1431 test(interceptor): Cover encoding error; refactor related tests, by paulmelnikow
💜 #1430 refactor(interceptor): Remove an archaic check, by paulmelnikow


COMMITS

Last week there were 14 commits.
🛠️ Updates from npm audit (#1444) Clear a ReDOS vulnerability. by paulmelnikow
🛠️ chore(package): update lockfile package-lock.json by greenkeeper[bot]
🛠️ chore(package): update nyc to version 13.2.0 by greenkeeper[bot]
🛠️ test(interceptor): Cover no 'fs' (#1439) Ref #1404 by paulmelnikow
🛠️ fix(socket): When Socket#setTimeout gets a callback, should still emit Ref #1404 by paulmelnikow
🛠️ fix(define): Throw when method is missing by paulmelnikow
🛠️ Throw when method is missing by paulmelnikow
🛠️ test(scope): Cover define with port in scope, and refactor tests by paulmelnikow
🛠️ refactor(test_recorder): Convert a couple to async; use arrow functions by paulmelnikow
🛠️ refactor(scope): Remove unreachable code in Scope constructor (#1434) The Scope constructor is not exported, so this code is unreachable. by paulmelnikow
🛠️ refactor(match_body): Remove dead code (#1433) It appears this function is only called from end in request_overrider, with body set to requestBody, which has already been converted from a buffer to a string. by paulmelnikow
🛠️ test(interceptor): Cover debug() call in match (#1432) by paulmelnikow
🛠️ test(interceptor): Cover encoding error; refactor related tests (#1431) Ref #1404 by paulmelnikow
🛠️ refactor(interceptor): Remove an archaic check (#1430) Ref #1404 by paulmelnikow


CONTRIBUTORS

Last week there were 2 contributors.
👤 paulmelnikow
👤 greenkeeper[bot]


STARGAZERS

Last week there were 46 stagazers.
arikimolloy
xmd404
stvmlbrn
tanem
ishiidaichi
anttih
devdammit
dylanitorium
HellMagic
iAbhyuday
karma10077
successgdc
hars-shhh
stilva
JasLin
thaewrapt
joaaomanooel
mlg87
rondymesquita
antonvorobyev
absognety
langyo
ieloielo
waken22
shreyasminocha
andreGarvin
dustinryerson
simone-sanfratello
ScoutYin
FrancescoXX
ManUtopiK
wing-puah
saeeddhqan
ironprice91
omeroy
Exitialis
JonasHavers
mattiasnixell
DemonCloud
ianva
mathsniper
nlevchuk
kizzlebot
Toba464
danieltwork
rnegron
You all are the stars! 🌟


RELEASES

Last week there was 1 release.
🚀 v11.0.0-beta.6@beta v11.0.0-beta.6


That's all for last week, please 👀 Watch and Star the repository nock/nock to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant