allowUnmocked + query string = interception fail

[NatalieWolfe]

What is the expected behavior?

When allowUnmocked is set to true there should be no change in how nock matches requests.

What is the actual behavior?

When allowUnmocked is set to true, query strings must be specified using the .query function, not in the path string.

Possible solution

This is sort of the opposite problem as #490, which was fixed in #955. That fix may have introduced this problem.

How to reproduce the issue

'use strict'

const nock = require('nock')
const http = require('http')

nock('http://localhost', {allowUnmocked: true})
  .get('/foo?bar=baz')
  .reply(418, 'Teapots')

const req = http.get('/foo?bar=baz', (res) => {
  console.log(res.statusCode)
})

req.on('error', console.error)

Does the bug have a test case?

Versions

Software	Version(s)
Nock	9.1.9, 10.0.6
Node	8.12.0, 10.15.1

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

[paulmelnikow]

Thanks for the test case!

Confirmed in 86c5c4f that the above prints:

{ Error: getaddrinfo ENOTFOUND localhost:80 localhost:80:80
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:57:26)
  errno: 'ENOTFOUND',
  code: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: 'localhost:80',
  host: 'localhost:80',
  port: 80 }

While removing { allowUnmocked: true } causes it to print:

418

Both versions work correctly if you use .query({ bar: 'baz' }) instead of the literal query string.

We don't outright say that literals are supported, though there is one example that uses them, and some tests which sort of imply as much.

Here are some todos:

• Fix the bug
• Add tests for query string literals, both with and without allowUnmocked
• Say explicitly in the readme that query string literals are allowed

[nockbot]

🎉 This issue has been resolved in version 11.0.0-beta.25 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[nockbot]

🎉 This issue has been resolved in version 11.0.0 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀