fix(intercept): Improve error message when new ClientMessage() is invoked with no options
#1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvoked with no options
In Node, it’s valid to invoke `new ClientMessage()` with no options. However, in Nock, this causes a crash:
Cannot read property 'proto' of undefined
stack: |
Object.normalizeRequestOptions (lib/common.js:12:27)
interceptorsFor (lib/intercept.js:139:10)
new OverriddenClientRequest (lib/intercept.js:263:26)
Test.t (tests/test_request_overrider.js:20:8)
Fixing that does not seem like a high priority, so this provides a better error message, while also removing related unreachable code.
RichardLitt
approved these changes
Jan 18, 2019
gr2m
approved these changes
Jan 19, 2019
|
🎉 This PR is included in version 11.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
…nvoked with no options (#1386) In Node, it’s valid to invoke `new ClientMessage()` with no options. However, in Nock, this causes a crash: Cannot read property 'proto' of undefined stack: | Object.normalizeRequestOptions (lib/common.js:12:27) interceptorsFor (lib/intercept.js:139:10) new OverriddenClientRequest (lib/intercept.js:263:26) Test.t (tests/test_request_overrider.js:20:8) Fixing that does not seem like a high priority, so this provides a better error message, while also removing related unreachable code.
gr2m
pushed a commit
that referenced
this pull request
Sep 4, 2019
…nvoked with no options (#1386) In Node, it’s valid to invoke `new ClientMessage()` with no options. However, in Nock, this causes a crash: Cannot read property 'proto' of undefined stack: | Object.normalizeRequestOptions (lib/common.js:12:27) interceptorsFor (lib/intercept.js:139:10) new OverriddenClientRequest (lib/intercept.js:263:26) Test.t (tests/test_request_overrider.js:20:8) Fixing that does not seem like a high priority, so this provides a better error message, while also removing related unreachable code.
gr2m
pushed a commit
that referenced
this pull request
Sep 5, 2019
…nvoked with no options (#1386) In Node, it’s valid to invoke `new ClientMessage()` with no options. However, in Nock, this causes a crash: Cannot read property 'proto' of undefined stack: | Object.normalizeRequestOptions (lib/common.js:12:27) interceptorsFor (lib/intercept.js:139:10) new OverriddenClientRequest (lib/intercept.js:263:26) Test.t (tests/test_request_overrider.js:20:8) Fixing that does not seem like a high priority, so this provides a better error message, while also removing related unreachable code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node, it’s valid to invoke
new ClientMessage()with no options. However, in Nock, this causes a crash:Fixing that does not seem like a high priority, so this provides a better error message, while also removing related unreachable code.