Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert https://github.com/nock/nock/pull/1270 #1335

Merged
merged 5 commits into from Jan 2, 2019
Merged

Revert https://github.com/nock/nock/pull/1270 #1335

merged 5 commits into from Jan 2, 2019

Conversation

Chengxuan
Copy link
Contributor

@Chengxuan Chengxuan commented Jan 2, 2019

fixes #1334

Forced pushed the branch to get Travis status on both commits.

@paulmelnikow
Copy link
Member

@gr2m What's the best way to land this? Should it go to both master and beta?

@gr2m
Copy link
Member

gr2m commented Jan 2, 2019

Merge into one of them, cherry pick into the other

@Chengxuan Chengxuan changed the title Issue1334 Revert https://github.com/nock/nock/pull/1270 Jan 2, 2019
@Chengxuan Chengxuan changed the title Revert https://github.com/nock/nock/pull/1270 Revert #1270 Jan 2, 2019
@Chengxuan Chengxuan changed the title Revert #1270 Revert https://github.com/nock/nock/pull/1270 Jan 2, 2019
@paulmelnikow
Copy link
Member

paulmelnikow commented Jan 2, 2019

@gr2m Okay, shall I merge this then? How's this look for a commit message?

fix: Mock responses should fire when timers are mocked

Revert #1270. Fix #1334.

@gr2m
Copy link
Member

gr2m commented Jan 2, 2019

How's this look for a commit message?

fix: Mock responses should fire when timers are mocked

Revert #1270. Fix #1334.

A+, would commit :)

@paulmelnikow paulmelnikow merged commit cb56669 into nock:master Jan 2, 2019
@nockbot
Copy link
Collaborator

nockbot commented Jan 2, 2019

🎉 This PR is included in version 10.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lock
Copy link

lock bot commented Jan 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants