Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue-1076): allowUnmocked: true + regexp host = interception fail #1179

Merged
merged 1 commit into from Jul 31, 2018
Merged

fix(issue-1076): allowUnmocked: true + regexp host = interception fail #1179

merged 1 commit into from Jul 31, 2018

Conversation

deeptiagrawa
Copy link
Contributor

@deeptiagrawa deeptiagrawa commented Jul 31, 2018 •
edited by gr2m

fixes #1076

@deeptiagrawa deeptiagrawa mentioned this pull request Jul 31, 2018
Closed
gr2m
gr2m approved these changes Jul 31, 2018
View reviewed changes
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 spot on, thank you so much Deepti, great work

@gr2m gr2m merged commit 907be86 into nock:master Jul 31, 2018
@nockbot
Copy link
Collaborator

nockbot commented Jul 31, 2018

🎉 This PR is included in version 9.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lock
Copy link

lock bot commented Sep 13, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deeptiagrawa @nockbot @gr2m