Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TransformOptions to allow enableImplicitConversion setting #2253

Closed
FSM1 opened this issue May 22, 2019 · 4 comments
Closed

Update TransformOptions to allow enableImplicitConversion setting #2253

FSM1 opened this issue May 22, 2019 · 4 comments

Comments

@FSM1
Copy link
Contributor

FSM1 commented May 22, 2019

I'm submitting a...


[ ] Regression 
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Setting the newly added enableImplicitConversion flag causes a TS error.

  app.useGlobalPipes(new ValidationPipe({
    whitelist: true,
    transform: true,
    transformOptions: {
       enableImplicitConversion: true,
    }
  }));

Expected behavior

The setting should be allowed.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Nest version: 6.0.4

 
For Tooling issues:
- Node version: 10.13.0  
- Platform: Windows 

Others:

@FSM1 FSM1 changed the title Update TransformOptions to allow implicitTypeConversion setting Update TransformOptions to allow enableImplicitConversion setting May 22, 2019
@kamilmysliwiec
Copy link
Member

This option has been introduced in the latest version of class-transformer package. Do you want to create a PR for this enhancement?

@FSM1
Copy link
Contributor Author

FSM1 commented May 22, 2019

thats is exactly the plan @kamilmysliwiec

I will submit the PR for this shortly.

@kamilmysliwiec
Copy link
Member

Published as 6.3.0

@BrunnerLivio BrunnerLivio added the needs triage This issue has not been looked into label Aug 8, 2019
@lock
Copy link

lock bot commented Nov 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants