Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add identity.launchWebAuthFlow() in metadata. #39

Merged
merged 1 commit into from Jan 9, 2018
Merged

feat: add identity.launchWebAuthFlow() in metadata. #39

merged 1 commit into from Jan 9, 2018

Conversation

regseb
Copy link
Contributor

@regseb regseb commented Jun 8, 2017

Promisify the browser.identity.launchWebAuthFlow() function (available since Firefox 53).

@thom4parisot
Copy link

Agreed!

However it would be a breaking change so ideally this package version should be major bumped.

@andreruffert
Copy link

Is there a chance of this getting merged?

To be able to use the identity.launchWebAuthFlow promise based API namespace it
adds the API metadata regarding to https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/identity/launchWebAuthFlow

I can confirm that it fixes the following error:

Uncaught Error: Invocation of form identity.launchWebAuthFlow(object)
doesn't match definition identity.launchWebAuthFlow(object details,
function callback)

Related issue:
#80

@rpl rpl self-requested a review January 9, 2018 15:23
@rpl rpl merged commit 13d0ced into mozilla:master Jan 9, 2018
@caitmuenster
Copy link

Merci, @regseb! We've added your contribution to our recognition wiki and I just vouched for your Mozillians profile. :)

Welcome onboard! I look forward to seeing you around.

@andreruffert andreruffert mentioned this pull request Jan 25, 2018
Adam42 added a commit to Adam42/pull-tabs that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants