Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser.sessions.* isn't polyfilled #52

Closed
eejdoowad opened this issue Aug 21, 2017 · 3 comments
Closed

browser.sessions.* isn't polyfilled #52

eejdoowad opened this issue Aug 21, 2017 · 3 comments

Comments

@eejdoowad
Copy link

No description provided.

@rotemdan
Copy link

rotemdan commented Mar 24, 2018

Since I needed this functionality I've made a custom build with the following added to api-metadata.json:

  "sessions": {
    "getDevices": {
      "minArgs": 0,
      "maxArgs": 1
    },
    "getRecentlyClosed": {
      "minArgs": 0,
      "maxArgs": 1
    },
    "restore": {
      "minArgs": 1,
      "maxArgs": 1
    }
  }

and it seems to work so far.

According to the chrome documentation these three methods are the only ones supported in Chrome.

Apparently there's an onChanged event as well but I'm not sure if it requires a polyfill of some sort.

Is this sufficient for a pull request? or the additional methods (currently Firefox-only) are needed as well?

@Rob--W
Copy link
Member

Rob--W commented Jul 5, 2018

This was fixed in 69e5876, and will be released in 0.3.0 (see #88).

@Rob--W
Copy link
Member

Rob--W commented Jul 19, 2018

@Rob--W Rob--W closed this as completed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants