fix: Fix deploy script so that it always publishes a production build. #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version `2.2.0` is broken because it's a development build.
rpl
approved these changes
Oct 13, 2017
.travis.yml
Outdated
| @@ -22,6 +22,9 @@ script: | |||
|
|
|||
| ## lint the github PR title. | |||
| - npm run travis-pr-title-lint | |||
| ## In case Travis is building a release tag, make sure we have a production build | |||
| ## before publishing to npm | |||
| - NODE_ENV=production npm run build | |||
There was a problem hiding this comment.
👍
I guess that we can use something like:
before_deploy:
- NODE_ENV=production npm run build
to run it only when we are release a new version on a tag build (https://docs.travis-ci.com/user/deployment/npm/#Running-commands-before-and-after-deploy)
There was a problem hiding this comment.
oh nice! I didn't know about that hook.
There was a problem hiding this comment.
That will keep the build running fast when we aren't doing a deploy
This was referenced Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1104
I think this will work but we'll have to cut a bug fix release to fully test it. If this works I'll file an issue to follow-up with some better safety checks so it doesn't happen again.