Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addons-linter to the latest version 🚀 #1076

Closed
wants to merge 1 commit into from

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Sep 12, 2017

Version 0.25.2 of addons-linter just got published.

Dependency addons-linter
Current Version 0.25.1
Type dependency

The version 0.25.2 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of addons-linter.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Commits

The new version differs by 16 commits.

  • 9d2c6da Prepare 0.25.2
  • 6147f04 Merge pull request #1528 from harry-7/warnonjs
  • 435d611 chore(package): update eslint-plugin-jest to version 21.0.2
  • 97a236d chore(package): update jest to version 21.0.2
  • c2d4a96 fix(package): update source-map-support to version 0.4.18
  • e223b1a Add CSP warning for unsafe-eval. (#1524)
  • 7b9b873 Added a check for type of script in warn-on-js
  • ea2a904 Update eslint-config-amo to 0.2.0
  • 3778e65 chore(package): update webpack to version 3.5.6
  • 11d5d27 fix(package): update postcss to version 6.0.11
  • ed6dc2f Merge pull request #1513 from mozilla/1459-fix-perm-test
  • 931b8b8 Merge pull request #1515 from mozilla/greenkeeper/eslint-4.6.1
  • cc63ff6 Fix eslint (indentation) errors
  • 9d4f45b Fix code and tests
  • 5c376b4 fix(package): update eslint to version 4.6.1

There are 16 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@kumar303
Copy link
Contributor

There is something really weird happening where the linter's eslint config is polluting web-ext's config. I don't know why that would happen. @EnTeQuAk any ideas on this?

@EnTeQuAk
Copy link

This is very weird indeed, couldn't find anything obvious yet (buggy eslint config / wrongfully linting node_modules or something like that).

I'll check out web-ext locally and see if I can reproduce this.

greenkeeper bot added a commit that referenced this pull request Sep 18, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Sep 18, 2017

Version 0.26.0 just got published.

Update to this version instead 🚀

Commits

The new version differs by 17 commits.

  • 6dfc726 Prepare release 0.26.0
  • 3faaafe Merge pull request #1545 from mozilla/greenkeeper/eslint-4.7.0
  • e57be76 fix(package): update eslint to version 4.7.0
  • 151bfbe Merge pull request #1544 from mozilla/greenkeeper/webpack-3.6.0
  • f909d0c Merge branch 'master' into greenkeeper/webpack-3.6.0
  • 5f0621d chore(package): update webpack to version 3.6.0
  • 7007f3f chore(package): update eslint-plugin-jest to version 21.1.0
  • c76355f chore(package): update jest to version 21.1.0
  • 6b5087f chore(package): update webpack-dev-server to version 2.8.2
  • e59c226 Merge pull request #1539 from mozilla/greenkeeper/babel-eslint-8.0.0
  • 864bf8e Merge pull request #1540 from mozilla/greenkeeper/webpack-dev-server-2.8.0
  • 007302d chore(package): update webpack-dev-server to version 2.8.0
  • 36e0d9a First version of detecting minified code. (#1525)
  • 3499114 Added bin folder to eslint scans (#1533)
  • dee5224 Merge pull request #1538 from mozilla/greenkeeper/whatwg-url-6.2.1

There are 17 commits in total.

See the full diff

@EnTeQuAk
Copy link

EnTeQuAk commented Sep 18, 2017

So I tried releasing 0.26.0 with the recent updates and an update to ESLint 4.7.0 which didn't help and I actually removed everything from node_modules locally that is from addons-linter which doesn't concern linting and the failures are still popping up. This is really weird, It's reproducible by upgrading to 0.25.2 which essentially did two things: Update to ESLint 4.x, update eslint-config-amo to 0.2.0 and add some minified code detection. All of these should be unrelated to whatever is happening in web-ext. Maybe something spills over from the eslint 4.x upgrade?

Difference between the both eslint runs with debug flag enabled: https://gist.github.com/EnTeQuAk/a5f000851be27eb829f33ac107cea115/revisions - so there's not any configs that are now read that weren't before or anything. Currently I have no idea tbh.

greenkeeper bot added a commit that referenced this pull request Sep 19, 2017
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Sep 19, 2017

Version 0.26.1 just got published.

Update to this version instead 🚀

Commits

The new version differs by 5 commits.

  • 738b556 Prepare release 0.26.1
  • a4fd7ec Merge pull request #1553 from mozilla/dont-scan-binary-or-flagged-files
  • ee50063 Don't count and scan flagged or binary files for badwords.
  • 9cd3b03 Merge pull request #1549 from mozilla/greenkeeper/eslint-4.7.1
  • 300ac82 fix(package): update eslint to version 4.7.1

See the full diff

@kumar303
Copy link
Contributor

I added more details about the bug in #1082

@kumar303 kumar303 closed this Sep 28, 2017
rpl pushed a commit that referenced this pull request Sep 29, 2017
…ional tests (#1082)

* fix(package): update addons-linter to version 0.26.1(closes #1076)
* fix: Add eslint 3.19.0 in the web-ext devDependencies (fix eslint linting errors on addons-linter 0.26.1)
* fix: Run functional tests with production npm dependencies on CI
@greenkeeper greenkeeper bot deleted the greenkeeper/addons-linter-0.25.2 branch September 29, 2017 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants