-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update addons-linter to the latest version 🚀 #1076
Conversation
There is something really weird happening where the linter's eslint config is polluting web-ext's config. I don't know why that would happen. @EnTeQuAk any ideas on this? |
This is very weird indeed, couldn't find anything obvious yet (buggy eslint config / wrongfully linting node_modules or something like that). I'll check out web-ext locally and see if I can reproduce this. |
Version 0.26.0 just got published.Update to this version instead 🚀 CommitsThe new version differs by 17 commits.
There are 17 commits in total. See the full diff |
So I tried releasing 0.26.0 with the recent updates and an update to ESLint 4.7.0 which didn't help and I actually removed everything from Difference between the both eslint runs with debug flag enabled: https://gist.github.com/EnTeQuAk/a5f000851be27eb829f33ac107cea115/revisions - so there's not any configs that are now read that weren't before or anything. Currently I have no idea tbh. |
Version 0.26.1 just got published.Update to this version instead 🚀 CommitsThe new version differs by 5 commits.
See the full diff |
I added more details about the bug in #1082 |
Version 0.25.2 of addons-linter just got published.
The version 0.25.2 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of addons-linter.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 16 commits.
9d2c6da
Prepare 0.25.2
6147f04
Merge pull request #1528 from harry-7/warnonjs
435d611
chore(package): update eslint-plugin-jest to version 21.0.2
97a236d
chore(package): update jest to version 21.0.2
c2d4a96
fix(package): update source-map-support to version 0.4.18
e223b1a
Add CSP warning for unsafe-eval. (#1524)
7b9b873
Added a check for type of script in warn-on-js
ea2a904
Update eslint-config-amo to 0.2.0
3778e65
chore(package): update webpack to version 3.5.6
11d5d27
fix(package): update postcss to version 6.0.11
ed6dc2f
Merge pull request #1513 from mozilla/1459-fix-perm-test
931b8b8
Merge pull request #1515 from mozilla/greenkeeper/eslint-4.6.1
cc63ff6
Fix eslint (indentation) errors
9d4f45b
Fix code and tests
5c376b4
fix(package): update eslint to version 4.6.1
There are 16 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴