Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added --no-input option to disable standard input #1044

Merged
merged 1 commit into from Aug 15, 2017

Conversation

serendicoder
Copy link
Contributor

Fixes #1030

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3359503 on serendicoder:web-ext-fix-1030 into 06ce2a2 on mozilla:master.

Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! When I filed the issue, I didn't realize it was such a small change :) Hopefully I'm not forgetting something else that needs changing.

@kumar303 kumar303 merged commit 99a1b40 into mozilla:master Aug 15, 2017
@serendicoder
Copy link
Contributor Author

@kumar303 , since you had mentioned adding noInput parameter in #1028 and not hooking it up in yargs, I made these PR changes. I wanted to know if tests are done for this feature. I am still new to the codebase and will bring up any issue, if noticed. Thanks.

@kumar303
Copy link
Contributor

I wanted to know if tests are done for this feature.

Yes, I think they are. We don't really have tests for the configuration of option parameters, unfortunately. We have a few integration tests but they are awkward and I wouldn't suggest adding one to test this feature. We need to improve web-ext in this regard -- i.e. introduce a way to test option configuration. I have some ideas like #65 .

@caitmuenster
Copy link

Thanks for your patch, @serendicoder! Your contribution has been added to our recognition wiki and your Mozillians profile has been vouched. :)

Welcome onboard! I look forward to seeing you around.

@serendicoder
Copy link
Contributor Author

Hi @caitmuenster , I changed my profile settings so my Mozillian profile is at https://mozillians.org/en-US/u/serendicoder/
Could you please vouch the same :) Thanks again!

@caitmuenster
Copy link

Hi @serendicoder! No problem -- that profile has just been vouched for. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants