Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run cmd accept custom manifest parser #1026

Merged
merged 1 commit into from Aug 3, 2017

Conversation

chrmod
Copy link
Contributor

@chrmod chrmod commented Aug 3, 2017

following up #1019 (comment)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f26cc03 on chrmod:run-custom-manifest-parser into 6dde038 on mozilla:master.

Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems reasonable. We can't guarantee that it won't break in the future in case we add more manifest parsing but, hey, it's worth a shot.

I think Appveyor is drunk so I'm just going to merge it.

@kumar303 kumar303 merged commit e48ac75 into mozilla:master Aug 3, 2017
@chrmod chrmod deleted the run-custom-manifest-parser branch August 3, 2017 18:32
@chrmod
Copy link
Contributor Author

chrmod commented Aug 3, 2017

awesome, thanks. two more to go

@caitmuenster
Copy link

Thanks so much @chrmod! Your contribution has been added to our recognition wiki and your Mozillians profile will be vouched. :)

Welcome onboard!

@chrmod
Copy link
Contributor Author

chrmod commented Aug 4, 2017

@caitmuenster that is great :) thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants