Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notion of editors #150

Open
leplatrem opened this issue Jan 24, 2022 · 0 comments
Open

Remove notion of editors #150

leplatrem opened this issue Jan 24, 2022 · 0 comments

Comments

@leplatrem
Copy link
Contributor

The editors group is used to limit the users allowed to request review on a collection.

We don't really need that. Being able to write on the collection is enough to be allowed to request review. And there is no reason why a reviewer could not request a review too (since they have write perms on the collection).

This would allow to remove a lot of duplicated lists in our permissions manifests, because for collections whose group of editors is the same as reviewers, we would just have:

cid:
  permissions:
      write:
          - /buckets/main/groups/cid-reviewers

And for the collections which have editors that are not reviewers, we would do:

cid:
   permissions:
      write:
          - ldap:editor1@mozilla.com
          - ldap:editor2@mozilla.com
          - /buckets/main/groups/cid-reviewers

This issue was initially reported here Kinto/kinto-signer#733

But it makes more sense to keep track of it here, along with #1945, #1946, #1948.


Imported from mozilla-services/kinto-dist#1952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant