Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify workflow configuration #148

Open
leplatrem opened this issue Jan 24, 2022 · 0 comments
Open

Simplify workflow configuration #148

leplatrem opened this issue Jan 24, 2022 · 0 comments

Comments

@leplatrem
Copy link
Contributor

leplatrem commented Jan 24, 2022

At the origins of kinto-signer, we had no preview collection.

We only had source -> destination and the to_review_enabled setting.

We introduce preview afterwards, and had two notions: review enabled and presence of preview collection.

In Remote Settings, we could simplify that and keep only have one notion:

  • all collections would have a preview collection (all would fall under /buckets/X -> /buckets/Y -> /buckets/Z
  • specific collections would have to_review_enabled = False

We could also remove the ability to have different collections names for preview and destination. For example, drop support of: /buckets/X/collections/A -> /buckets/X/collections/B -> /buckets/X/collections/C.

Caution: we may have to maintain some metadata in the capabilities, since it's used by Kinto Admin. See https://github.com/Kinto/kinto-admin/blob/e5792ea176192d42d61086588f9622e40876ee9b/src/plugins/signoff/sagas.ts#L378-L394


Imported from mozilla-services/kinto-dist#1946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant