Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request comments made directly in the RS Writer persist for other requests #134

Open
heres-maria-sv-inactive opened this issue Nov 4, 2021 · 1 comment

Comments

@heres-maria-sv-inactive
Copy link

[Prerequisites]:

  • Have rights to Remote Settings Stage that allow you to make changes to some collections.
  • Be connected to the corporate VPN.

[Steps to reproduce]:

  1. Open the RS Writer page on the collection you want to modify (e.g. main-workspace/nimbus-mobile-experiments).
  2. Modify one of the records and click “Update record”.
  3. Click “Request review”.
  4. Write a comment and click “Request review”.
  5. Have someone use the Nimbus page to request an experiment launch review for the same collection.
  6. Open the Simple Review page and observe the message displayed for the review request.

[Expected result]:

  • Comments left for direct review requests from the RS Writer are not kept for all further review requests.

[Actual result]:

  • Comments left for direct review requests from the RS Writer are kept for all further review requests (launch experiment and end enrollment).

[Notes]:

  • Attached is a recording of the issue
    comment RS
    .
@leplatrem
Copy link
Contributor

Thanks for reporting this!

This is weird, we do reset he last_editor_comment field when a review is requested:
https://github.com/Kinto/kinto-signer/blob/42080112bd8a96ce1c1d3e39cfef83851f643da3/kinto_signer/updater.py#L417-L419

Note: Experimenter could also set an explicit value for this field here https://github.com/mozilla/experimenter/blob/cf1e50aa07c08d34b6cd7183308d19641877ae13/app/experimenter/kinto/client.py#L32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants