Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Node.js 21 pin in the GitHub Actions CI workflow #18049

Open
timvandermeij opened this issue May 6, 2024 · 0 comments
Open

Remove the Node.js 21 pin in the GitHub Actions CI workflow #18049

timvandermeij opened this issue May 6, 2024 · 0 comments
Labels

Comments

@timvandermeij
Copy link
Contributor

In PR #18009 the GitHub Actions CI workflow has temporary been updated to not use the latest Node.js version (22 as of writing) but Node.js 21 instead because the canvas dependency doesn't provide pre-built binaries for Node 22.js yet. We don't want to build it ourselves because that'd require additional complexity for local and workflow installations, and sadly it looks like this may take some time to resolve upstream given that Automattic/node-canvas#2377 and the corresponding release tracking issue Automattic/node-canvas#2232 didn't have recent updates. To avoid having failing builds in the meantime, we chose to pin Node.js to version 21 for the time being.

If Automattic/node-canvas#2377 is resolved upstream and a new release is published with pre-built binaries, we should update to that new version and revert e561a4a so we test against the latest version again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant