Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Chrome prototype: get browser-polyfill.js via build tools #4304

Closed
jaredhirsch opened this issue Apr 3, 2018 · 4 comments
Closed

Chrome prototype: get browser-polyfill.js via build tools #4304

jaredhirsch opened this issue Apr 3, 2018 · 4 comments

Comments

@jaredhirsch
Copy link
Member

Two tasks here:

  1. Make sure outstanding issues with the browser-polyfill are resolved in that repo's master. Currently I believe feat: Added support for the sendResponse callback in the runtime.onMessage listeners mozilla/webextension-polyfill#97 is the one we need to land.

  2. Add something to the build tools to fetch the browser-polyfill, build it, and add it to the Chrome build folder.

Refs #3998

@jaredhirsch
Copy link
Member Author

Just heard from @rpl today that he's working with @Rob--W to finish up the PR. We can check on the PR in another week or two.

In the meantime, it would be good to update the polyfill to the latest version in the PR, as it might behave differently in some failure cases.

@ghost ghost added this to the Sprint 10 (61-2) ⛅ milestone Apr 5, 2018
@ghost ghost modified the milestones: Sprint 11 (61-3) 👗, Sprint 12 (62-0) 👁 Apr 30, 2018
@ghost ghost assigned jaredhirsch Apr 30, 2018
@jaredhirsch
Copy link
Member Author

The upstream PR is still not merged. Probably need to kick this to next sprint.

@jaredhirsch
Copy link
Member Author

The upstream PR has landed, but a new version hasn't been released yet. Filed mozilla/webextension-polyfill#150 to ask for a patch release.

@ghost ghost modified the milestones: Sprint 18 (63-2), Sprint 20 (64-1) Aug 2, 2018
@jaredhirsch jaredhirsch removed their assignment Jan 3, 2019
@ianb
Copy link
Contributor

ianb commented Feb 7, 2019

I don't think we're going to launch on Chrome

@ianb ianb closed this as completed Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants