Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: ESLint v6.8 #4138

Merged
merged 1 commit into from Feb 1, 2020
Merged

Upgrade: ESLint v6.8 #4138

merged 1 commit into from Feb 1, 2020

Conversation

kaicataldo
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

While working on eslint/eslint-canary#27 I noticed that Mocha is still on ESLint v5. This PR updates ESLint and all its dependencies to their latest versions, as well as fixing any new errors that crop up as a result. Please look over the code changes and let me know if you see anything amiss, as I don't have a lot of context here.

Alternate Designs

N/A

Why should this be in core?

N/A

Benefits

We're starting to work on ESLint v7, so it would be great to get Mocha on the latest current version to ease upgrading in the future.

Possible Drawbacks

Unintended regressions from code changes from fixing new warnings.

Applicable issues

Thanks for maintaining Mocha!

@jsf-clabot
Copy link

jsf-clabot commented Jan 3, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jan 3, 2020 •
edited

Coverage Status

Coverage increased (+0.07%) to 92.869% when pulling 014ba0e on kaicataldo:update-eslint into 24c22be on mochajs:master.

@kaicataldo
Copy link
Contributor Author

Anything else I can do here to help land this?

@kaicataldo
Copy link
Contributor Author

One more friendly ping :)

@outsideris outsideris added the type: chore generally involving deps, tooling, configuration, etc. label Jan 19, 2020
juergba
juergba reviewed Jan 23, 2020
View reviewed changes
package.json Show resolved Hide resolved
juergba
juergba reviewed Jan 23, 2020
View reviewed changes
Copy link
Member

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have some small questions.

@kaicataldo
Copy link
Contributor Author

Thanks for the review! Please let me know if you have any other questions :)

@kaicataldo
Copy link
Contributor Author

Please let me know if you have any other questions.

@juergba juergba added this to the next milestone Jan 31, 2020
juergba
juergba approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaicataldo thank you!

@juergba juergba merged commit 2a1b637 into mochajs:master Feb 1, 2020
@juergba juergba added the qa label Feb 1, 2020
@kaicataldo kaicataldo deleted the update-eslint branch February 7, 2020 01:58
@kaicataldo kaicataldo mentioned this pull request Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba approved these changes

Assignees
No one assigned
Labels
type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kaicataldo @jsf-clabot @coveralls @juergba @outsideris