Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage author list in AUTHORS instead package.json #4058

Merged
merged 5 commits into from Jan 30, 2020

Conversation

outsideris
Copy link
Member

@outsideris outsideris commented Oct 9, 2019

Currently, the contributor list managed in package.json. However, it is too long.
So, we moved the list into AUTHORS

close #4053

@outsideris outsideris added area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Oct 9, 2019
@coveralls
Copy link

coveralls commented Oct 9, 2019

Coverage Status

Coverage increased (+0.07%) to 92.925% when pulling bf1cd2d on outsideris:extract-authors into d0f04e9 on mochajs:master.

Copy link
Member

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per boneskull's comment

ensure the AUTHORS file is written to at publish time

above part is missing.

@outsideris outsideris force-pushed the extract-authors branch 2 times, most recently from 34d833c to 5486dc5 Compare October 13, 2019 09:33
@outsideris
Copy link
Member Author

I updated to run update-authors.js when run npm start version.

@outsideris
Copy link
Member Author

I also updated maintainer's guide for releasing.

package-scripts.js Outdated Show resolved Hide resolved
@juergba juergba added this to the next milestone Jan 27, 2020
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris
Copy link
Member Author

Anyway, I rebased this onto master and updated AUTHORS.

Signed-off-by: Outsider <outsideris@gmail.com>
Copy link
Member

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outsideris thank you, lgtm.

@juergba juergba merged commit dbba276 into mochajs:master Jan 30, 2020
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
@mochajs mochajs deleted a comment from jdaykin454 Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage contributors in package.json
4 participants