Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix --ui issues, closes #3746 #3756

Merged
merged 1 commit into from Feb 21, 2019
Merged

fix --ui issues, closes #3746 #3756

merged 1 commit into from Feb 21, 2019

Conversation

boneskull
Copy link
Member

also move all ui-related tests into test/integration/options/ui.spec.js

@boneskull boneskull added type: bug a defect, confirmed by a maintainer semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Feb 20, 2019
@boneskull boneskull self-assigned this Feb 20, 2019
@boneskull boneskull mentioned this pull request Feb 20, 2019
Closed
4 tasks
@boneskull boneskull added this to the next milestone Feb 20, 2019
plroebuck
plroebuck approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@plroebuck plroebuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, though I really don't like your variable name factory (since it isn't one). Maybe _interface (since we can't use the word itself).

@boneskull
fix --ui issues, closes #3746
be7da93 
move all ui-related tests into `test/integration/options/ui.spec.js`
@boneskull
Copy link
Member Author

yeah, factory is a misnomer. looking more closely, I realized that this._ui is actually a) undefined and b) never referenced.

@boneskull boneskull merged commit 7926f47 into master Feb 21, 2019
@boneskull boneskull deleted the boneskull/issue/3746 branch February 21, 2019 03:46
This was referenced Oct 26, 2019
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plroebuck plroebuck plroebuck approved these changes

Assignees

@boneskull boneskull

Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Milestone
v6.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boneskull @plroebuck