Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent calculation of duration #3187

Merged
merged 1 commit into from Jan 2, 2018
Merged

Conversation

FND
Copy link
Contributor

@FND FND commented Jan 2, 2018

Description of the Change

minor adjustment; probably doesn't make much of a difference, but seems more correct this way

Alternate Designs

N/A

Why should this be in core?

N/A

Benefits

  • minor performance enhancement
  • slightly more consistent reporting

Possible Drawbacks

none, I hope

Applicable issues

N/A

probably doesn't make much of a difference, but seems more correct
@jsf-clabot
Copy link

jsf-clabot commented Jan 2, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.018% when pulling e5d8cf5 on FND:patch-1 into 5161639 on mochajs:master.

@boneskull
Copy link
Member

yes, that seems more correct to me. thanks

@boneskull boneskull added type: bug a defect, confirmed by a maintainer semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Jan 2, 2018
@boneskull boneskull merged commit 3e85f89 into mochajs:master Jan 2, 2018
@boneskull boneskull added this to the next milestone Jan 2, 2018
@FND FND deleted the patch-1 branch January 3, 2018 08:21
This was referenced Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants