Project-local custom reporters

[cletusw]

According to the wiki, you can

define custom third-party reporters within your own test suite, or by using npm modules

The second part ("reporters that are npm modules") works fine, but when I try to use a project-local custom reporter, I'm forced to specify the path relative to node_modules/mocha/lib/.

That is, supposing I have a custom-reporter.js in the root of my project, running

node_modules/.bin/mocha --reporter=./custom-reporter.js

fails, but

node_modules/.bin/mocha --reporter=../../../custom-reporter.js

works.

It would instead be nice if the --reporter option were relative to the current directory for non-npm reporters.

Here's the relevant line that needs fixing. It would need to fall back to something like path.resolve(process.cwd(), reporter). I can try to put together a PR, but I want to make sure I'm not missing something.

[boneskull]

@cletusw Sounds about right. Just nest another try/catch with path.join(process.cwd(), reporter) or something. path.resolve() should work as well.

[cletusw]

Will do.

[cletusw]

@boneskull On a related note, what's the difference between that code in lib/mocha.js and

mocha/bin/_mocha

Lines 209 to 220 in 2a51080

	// load reporter
	var Reporter = null;
	try {
	Reporter = require('../lib/reporters/' + program.reporter);
	} catch (err) {
	try {
	Reporter = require(program.reporter);
	} catch (err) {
	throw new Error('reporter "' + program.reporter + '" does not exist');
	}
	}

?

[cletusw]

That code is causing errors after my fix, but it looks like Reporter is not actually used anywhere. Does that sound right?

[dasilvacontin]

This feature has been released in v3.3.0! 🎉

[AndersDJohnson]

I can't get this to work with v4.0.1.

[ScottFreeCode]

Try removing any leading ./; see #2659 (comment) for details (it's been a while but I think my recommendations # 1 and # 2 would cover getting this fix to actually work, while # 3 and # 4 expand the idea to other similar issues).