From a7267b4b49c423abe0924e865597caa1750416c6 Mon Sep 17 00:00:00 2001 From: Christopher Hiller Date: Tue, 16 Jan 2018 21:08:42 -0800 Subject: [PATCH] remove more references to make and Makefile --- .editorconfig | 3 --- .github/CONTRIBUTING.md | 3 ++- docs/index.md | 17 +++++------------ karma.conf.js | 2 +- 4 files changed, 8 insertions(+), 17 deletions(-) diff --git a/.editorconfig b/.editorconfig index 47ce1a5519..e09b844f73 100644 --- a/.editorconfig +++ b/.editorconfig @@ -10,6 +10,3 @@ insert_final_newline = true trim_trailing_whitespace = true indent_style = space indent_size = 2 - -[Makefile] -indent_style = tab diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index acbcd3b21c..dc7b817cca 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -40,8 +40,9 @@ We ask you please keep these goals in mind when making or proposing changes. Follow these steps to get going. If you are having trouble, don't be afraid to [ask for help](#got-a-question). +> PRO TIP: Run `npm start` to see a list of commands which can be run with `npm start ` + 1. [Install Node.js 4.x or newer](https://nodejs.org/download). -1. Install [GNU Make](https://www.gnu.org/software/make/) or equivalent. 1. Follow [Github's documentation](https://help.github.com/articles/fork-a-repo/) on setting up Git, forking and cloning. 1. Create a new branch in your working copy. Give your branch a descriptive name, such as `issue/12345`: `git checkout -b issue/12345`. 1. Execute `npm install` to install the development dependencies. diff --git a/docs/index.md b/docs/index.md index e609d9b291..4afd907bb1 100644 --- a/docs/index.md +++ b/docs/index.md @@ -1149,16 +1149,13 @@ The command `mocha --reporter doc array` would yield: ``` -The SuperAgent request library [test documentation](https://visionmedia.github.io/superagent/docs/test.html) was generated with Mocha's doc reporter using this simple make target: +The SuperAgent request library [test documentation](https://visionmedia.github.io/superagent/docs/test.html) was generated with Mocha's doc reporter using this Bash command: -```makefile -test-docs: - $(MAKE) test REPORTER=doc \ - | cat docs/head.html - docs/tail.html \ - > docs/test.html +```bash +$ mocha --reporter=doc | cat docs/head.html - docs/tail.html > docs/test.html ``` -View the entire [Makefile](https://github.com/visionmedia/superagent/blob/master/Makefile) for reference. +View SuperAgent's [Makefile](https://github.com/visionmedia/superagent/blob/master/Makefile) for reference. ### Markdown @@ -1275,11 +1272,7 @@ The following editor-related packages are available: ### TextMate -The Mocha TextMate bundle includes snippets to make writing tests quicker and more enjoyable. To install the bundle, clone a copy of the [Mocha repo](https://github.com/mochajs/mocha), and run: - -```sh -$ make tm -``` +The [Mocha TextMate bundle](https://github.com/mochajs/mocha.tmbundle) includes snippets to make writing tests quicker and more enjoyable. ### JetBrains diff --git a/karma.conf.js b/karma.conf.js index 332ba9be0d..9220baecd4 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -64,7 +64,7 @@ module.exports = config => { }; // TO RUN AGAINST SAUCELABS LOCALLY, execute: - // `CI=1 SAUCE_USERNAME= SAUCE_ACCESS_KEY= make test-browser` + // `CI=1 SAUCE_USERNAME= SAUCE_ACCESS_KEY= npm start test.browser` const env = process.env; let sauceConfig;