Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[name]ModelSelector requires passing 'undefined' instead of empty for non-primitive fields #407

Open
wtuminski opened this issue Dec 27, 2022 · 1 comment

Comments

@wtuminski
Copy link
Contributor

I tried to upgrade mst-gql in my project, but when I did so it turned out that I must pass undefined to every empty selector builder of a non-primitive field. In many queries, I want to get only a reference so when invoking the selector builder for a non-primitive field I pass no arguments. The builder argument is now required, but undefined is acceptable. Can't we return to the optional argument?

@wtuminski wtuminski changed the title QueryBuilder requires passing 'undefined' instead of empty [name]ModelSelector requires passing 'undefined' instead of empty for non-primitive fields Dec 27, 2022
@wtuminski
Copy link
Contributor Author

wtuminski commented Dec 27, 2022

The solution is introduced in the following PR: #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant