Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add observable queue #892

Closed
wants to merge 3 commits into from
Closed

feat: add observable queue #892

wants to merge 3 commits into from

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Jan 27, 2023 •
edited

Describe the changes proposed in this Pull Request.

Fixes #887

Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melo run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

@amondnet amondnet self-assigned this Jan 27, 2023
@amondnet amondnet linked an issue Jan 27, 2023 that may be closed by this pull request
Type Queue in mobx #887
Open
@codecov
Copy link

codecov bot commented Jan 27, 2023 •
edited

Codecov Report

Merging #892 (03e2d15) into master (13b7e6d) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   98.96%   99.04%   +0.08%     
==========================================
  Files          55       56       +1     
  Lines        1924     2105     +181     
==========================================
+ Hits         1904     2085     +181     
  Misses         20       20
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.70% <100.00%> (+0.17%) ⬆️
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/api/observable_collections/observable_queue.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b7e6d...03e2d15. Read the comment docs.

@amondnet amondnet marked this pull request as ready for review January 27, 2023 15:41
@amondnet amondnet requested a review from fzyzcjy February 3, 2023 17:36
fzyzcjy
fzyzcjy reviewed Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@fzyzcjy fzyzcjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is similar to ObservableList (and/or other observable collections?) So is it possible we somehow extract the common code to avoid code duplication

@pavanpodila
Copy link
Member

closing this as its gone stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzyzcjy fzyzcjy fzyzcjy left review comments

@pavanpodila pavanpodila Awaiting requested review from pavanpodila

Assignees

@amondnet amondnet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type Queue in mobx
3 participants
@amondnet @pavanpodila @fzyzcjy