Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a Dart DevTools tab for MobX #215

Open
pavanpodila opened this issue Jul 10, 2019 · 18 comments
Open

Build a Dart DevTools tab for MobX #215

pavanpodila opened this issue Jul 10, 2019 · 18 comments
Labels
enhancement New feature or request help wanted Extra attention is needed investigation Needs some research and investigation

Comments

@pavanpodila
Copy link
Member

Start by creating a PR in this repo: https://github.com/flutter/devtools

Refer to the Design Doc for the potential features.

@pavanpodila pavanpodila added enhancement New feature or request help wanted Extra attention is needed investigation Needs some research and investigation labels Jul 10, 2019
@rrousselGit
Copy link
Collaborator

Oh, I'll definitely follow that one.

@rrousselGit
Copy link
Collaborator

Depending on what's possible, yes. But that's unrelated to Mobx.

@rrousselGit
Copy link
Collaborator

@pavanpodila have you tried anything or found documentation explaining how to add a custom screen on the devtool?

@pavanpodila
Copy link
Member Author

pavanpodila commented Jul 28, 2019

I spoke to Jacob, an architect from the Flutter DevTools team, who suggested I start with the Logging screen: https://github.com/flutter/devtools/tree/master/packages/devtools/lib/src/logging.

That is an example of adding a new screen/tab to the DevTools interface

@rrousselGit
Copy link
Collaborator

So that means it'd be built in the dev tool?

I'm not sure that's a good idea. I don't see how that'd scale as the flutter community grows.

What about a browser extension instead? It'd detect that the page is from the devtools, and add a tab manually.

@pavanpodila
Copy link
Member Author

Ya from what I learnt, there is no extensibility built in for third party. With mobx we will become the first extension 😀

@pavanpodila pavanpodila pinned this issue Aug 6, 2019
@talamaska
Copy link

@pavanpodila @rrousselGit Instead of trying to link with flutter dev tools, I would suggest another approach, the one that flutter redux uses. Instead, by using redux_remote_devtools, you are able to debug the store in remote dev tools by running your own server. I would like to see the same for mobx since the js version already is kinda supporting this via mobx-remotedev. Please invest some time into this, cause now the mobx is a blackbox in flutter I'm not sure what's going on, I need to put breakpoints and debugPrints in order to see if the action is fired or what I have in the store.

@rrousselGit
Copy link
Collaborator

From the 4.0.0 of provider and onward, providers correctly implement the diagnostic methods needed to see the current value on the devtool

Which means if you're using provider to pass your stores (and have a proper toString), you should be able to see their content

@talamaska
Copy link

right but how to link providers to the remote dev server? Or you mean the flutter dev tools not the redux one?

@rrousselGit
Copy link
Collaborator

Flutter devtools, yes

@yshean
Copy link

yshean commented Feb 19, 2020

hi there, are you guys currently working on this? is there a specific direction on what approach will be used? e.g. something like redux_remote_devtools, a tab on dart dev tool, a browser extension, or something else?

@pavanpodila
Copy link
Member Author

Work has not started on this. We want to target the Flutter Dev Tools first.

@fzyzcjy
Copy link
Collaborator

fzyzcjy commented Jan 20, 2021

Hi one year has passed :) Are there any updates?

@alsoLut
Copy link

alsoLut commented Jun 20, 2021

any news?

@Rohithgilla12
Copy link

Hello I really want to build this tool, but don't have prior experience on building the devtools.

If the making it PR to the official flutter/devtools is a hassle, we can make it as a standalone application.

@fzyzcjy it would be very helpful if you can help with references on how to create a standalone application that would interact with the main application.

I remember it from the convenient_test_manager!

Would appreciate any help from anyone getting it started!

Thanks

@fzyzcjy
Copy link
Collaborator

fzyzcjy commented Sep 7, 2022

@Rohithgilla12

how to create a standalone application that would interact with the main application

My convenient_test_manager uses grpc. the manager is a desktop app and it serves as a grpc server; the worker is the android/ios/... app and it is a grpc client connecting to that "server".

Btw, I am curious where do you find me from this issue?

@Rohithgilla12
Copy link

@fzyzcjy Thanks will check it out.

Found from #215 (comment) and I also remember the convenient_test_manager its an amazing package!

@fzyzcjy
Copy link
Collaborator

fzyzcjy commented Sep 7, 2022

@Rohithgilla12 Haha I see. You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed investigation Needs some research and investigation
Projects
None yet
Development

No branches or pull requests

7 participants