Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isDone logic is backwards #22

Open
dmorgantini opened this issue Jun 16, 2015 · 5 comments
Open

isDone logic is backwards #22

dmorgantini opened this issue Jun 16, 2015 · 5 comments

Comments

@dmorgantini
Copy link

isDone returns isNotDone.

https://github.com/mmalecki/hock/blob/master/lib/request.js#L258
@JDongian
Copy link

#23 Fixed it :)

@JDongian JDongian mentioned this issue Jun 24, 2015
Open
@kenperkins
Copy link
Collaborator

Correct me if I'm wrong, but this would be a semver major change?

@kenperkins
Copy link
Collaborator

It's hard to say. It was a bug (how did I implement that wrong?) but it will break anyone who uses Hock.

Thoughts?

@JDongian
Copy link

It looked like internals, but since it gets exported https://github.com/mmalecki/hock/blob/master/lib/request.js#L287 I think you could justify a version update.

@JDongian
Copy link

Would you rather change the function name to isNotDone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmorgantini @kenperkins @JDongian