fix corner case in if_return (#3601)

fixes #3600
mishoo · Nov 19, 2019 · d959e0b · d959e0b
1 parent 67278e7
commit d959e0b
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/lib/compress.js b/lib/compress.js
@@ -1805,6 +1805,7 @@ merge(Compressor.prototype, {
                         stat.alternative = make_node(AST_BlockStatement, stat, {
                             body: body
                         });
+                        statements[i] = stat;
                         statements[i] = stat.transform(compressor);
                         continue;
                     }
@@ -1817,6 +1818,7 @@ merge(Compressor.prototype, {
                             stat.condition = negated;
                             statements[j] = stat.body;
                             stat.body = next;
+                            statements[i] = stat;
                             statements[i] = stat.transform(compressor);
                             continue;
                         }
@@ -1834,6 +1836,7 @@ merge(Compressor.prototype, {
                         stat.alternative = make_node(AST_BlockStatement, stat.alternative, {
                             body: body
                         });
+                        statements[i] = stat;
                         statements[i] = stat.transform(compressor);
                         continue;
                     }

diff --git a/test/compress/if_return.js b/test/compress/if_return.js
@@ -544,3 +544,32 @@ if_body_return_3: {
         "PASS",
     ]
 }
+
+issue_3600: {
+    options = {
+        if_return: true,
+        inline: true,
+        side_effects: true,
+        unused: true,
+    }
+    input: {
+        var c = 0;
+        (function() {
+            if ([ ][c++]); else return;
+            return void function() {
+                var b = --b, a = c = 42;
+                return c;
+            }();
+        })();
+        console.log(c);
+    }
+    expect: {
+        var c = 0;
+        (function() {
+            if ([][c++]) b = --b, c = 42;
+            var b;
+        })();
+        console.log(c);
+    }
+    expect_stdout: "1"
+}