fix corner case in side_effects (#3514)

fixes #3512
mishoo · Oct 22, 2019 · a53ab99 · a53ab99
1 parent 02308a7
commit a53ab99
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/lib/compress.js b/lib/compress.js
@@ -4196,7 +4196,7 @@ merge(Compressor.prototype, {
             var left = this.left;
             if (left instanceof AST_PropAccess) {
                 var expr = left.expression;
-                if (expr instanceof AST_Assign && !expr.may_throw_on_access(compressor)) {
+                if (expr instanceof AST_Assign && expr.operator == "=" && !expr.may_throw_on_access(compressor)) {
                     expr.write_only = "p";
                 }
                 if (compressor.has_directive("use strict") && expr.is_constant()) return this;

diff --git a/test/compress/functions.js b/test/compress/functions.js
@@ -3340,3 +3340,33 @@ issue_3506_3: {
     }
     expect_stdout: "PASS"
 }
+
+issue_3512: {
+    options = {
+        collapse_vars: true,
+        pure_getters: "strict",
+        sequences: true,
+        side_effects: true,
+        unused: true,
+    }
+    input: {
+        var a = "PASS";
+        (function(b) {
+            (function() {
+                b <<= this || 1;
+                b.a = "FAIL";
+            })();
+        })();
+        console.log(a);
+    }
+    expect: {
+        var a = "PASS";
+        (function(b) {
+            (function() {
+                (b <<= this || 1).a = "FAIL";
+            })();
+        })(),
+        console.log(a);
+    }
+    expect_stdout: "PASS"
+}