fix corner case in collapse_vars (#3672)

fixes #3671
mishoo · Jan 7, 2020 · 4d6771b · 4d6771b
1 parent d171911
commit 4d6771b
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/lib/compress.js b/lib/compress.js
@@ -1367,7 +1367,7 @@ merge(Compressor.prototype, {
                 if (replace_all) return false;
                 return node instanceof AST_SymbolRef
                     && !node.is_declared(compressor)
-                    && !(parent instanceof AST_Assign && parent.left === node);
+                    && !(parent instanceof AST_Assign && parent.operator == "=" && parent.left === node);
             }
 
             function in_conditional(node, parent) {

diff --git a/test/compress/collapse_vars.js b/test/compress/collapse_vars.js
@@ -7464,3 +7464,30 @@ issue_3651: {
     }
     expect_stdout: "PASS"
 }
+
+issue_3671: {
+    options = {
+        collapse_vars: true,
+    }
+    input: {
+        var a = 0;
+        try {
+            a++;
+            A += 0;
+            a = 1 + a;
+        } catch (e) {
+            console.log(a);
+        }
+    }
+    expect: {
+        var a = 0;
+        try {
+            a++;
+            A += 0;
+            a = 1 + a;
+        } catch (e) {
+            console.log(a);
+        }
+    }
+    expect_stdout: "1"
+}