Skip to content

Commit

Permalink
fix rename (#2501)
Browse files Browse the repository at this point in the history
- suppress spurious `rename` from `commander`
- handle `AST_SymbolCatch` correctly
  • Loading branch information
alexlamsl committed Nov 23, 2017
1 parent f4e2fb9 commit 30cfea2
Show file tree
Hide file tree
Showing 4 changed files with 547 additions and 3 deletions.
1 change: 1 addition & 0 deletions bin/uglifyjs
Expand Up @@ -72,6 +72,7 @@ if (!program.output && program.sourceMap && program.sourceMap.url != "inline") {
"wrap"
].forEach(function(name) {
if (name in program) {
if (name == "rename" && program[name]) return;
options[name] = program[name];
}
});
Expand Down
9 changes: 6 additions & 3 deletions lib/scope.js
Expand Up @@ -456,6 +456,7 @@ AST_Toplevel.DEFMETHOD("find_unique_prefix", function(options) {
this.globals.each(add_def);
this.walk(new TreeWalker(function(node) {
if (node instanceof AST_Scope) node.variables.each(add_def);
if (node instanceof AST_SymbolCatch) add_def(node.definition());
}));
var prefix, i = 0;
do {
Expand Down Expand Up @@ -492,17 +493,19 @@ AST_Toplevel.DEFMETHOD("expand_names", function(options) {
this.globals.each(rename);
this.walk(new TreeWalker(function(node) {
if (node instanceof AST_Scope) node.variables.each(rename);
if (node instanceof AST_SymbolCatch) rename(node.definition());
}));

function rename(def) {
if (def.global || def.unmangleable(options)) return;
if (member(def.name, options.reserved)) return;
var name = prefix + def.id;
var d = def.redefined();
def.name = d ? d.name : prefix + def.id;
def.orig.forEach(function(sym) {
sym.name = name;
sym.name = def.name;
});
def.references.forEach(function(sym) {
sym.name = name;
sym.name = def.name;
});
}
});
Expand Down

0 comments on commit 30cfea2

Please sign in to comment.