fix corner case in booleans (#3691)

fixes #3690
mishoo · Jan 27, 2020 · 0dcedad · 0dcedad
1 parent 36a430c
commit 0dcedad
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/lib/compress.js b/lib/compress.js
@@ -4453,15 +4453,15 @@ merge(Compressor.prototype, {
                 var ev = value.is_truthy() || value.tail_node().evaluate(compressor);
                 if (!ev) {
                     value = value.drop_side_effect_free(compressor);
-                    if (node.value !== value) node.value = value ? make_sequence(node.value, [
+                    node.value = value ? make_sequence(node.value, [
                         value,
                         make_node(AST_Number, node.value, {
                             value: 0
                         })
                     ]) : null;
                 } else if (ev && !(ev instanceof AST_Node)) {
                     value = value.drop_side_effect_free(compressor);
-                    if (node.value !== value) node.value = value ? make_sequence(node.value, [
+                    node.value = value ? make_sequence(node.value, [
                         value,
                         make_node(AST_Number, node.value, {
                             value: 1

diff --git a/test/compress/booleans.js b/test/compress/booleans.js
@@ -131,3 +131,25 @@ issue_3658: {
     }
     expect_stdout: "PASS"
 }
+
+issue_3690: {
+    options = {
+        booleans: true,
+        unused: true,
+    }
+    input: {
+        console.log(function(a) {
+            return function() {
+                return a = [ this ];
+            }() ? "PASS" : "FAIL";
+        }());
+    }
+    expect: {
+        console.log(function(a) {
+            return function() {
+                return 1;
+            }() ? "PASS" : "FAIL";
+        }());
+    }
+    expect_stdout: "PASS"
+}