fix corner case in dead_code & ie8 (#3494)

fixes #3493
mishoo · Oct 17, 2019 · 0785a15 · 0785a15
1 parent b1279a4
commit 0785a15
Show file tree

Hide file tree

Showing 2 changed files with 76 additions and 2 deletions.
diff --git a/lib/compress.js b/lib/compress.js
@@ -888,8 +888,10 @@ merge(Compressor.prototype, {
     });
 
     AST_SymbolRef.DEFMETHOD("is_immutable", function() {
-        var orig = this.definition().orig;
-        return orig.length == 1 && orig[0] instanceof AST_SymbolLambda;
+        var def = this.definition();
+        if (def.orig.length != 1) return false;
+        var sym = def.orig[0];
+        return sym instanceof AST_SymbolLambda && def.scope.name === sym;
     });
 
     function is_lhs_read_only(lhs, compressor) {

diff --git a/test/compress/ie8.js b/test/compress/ie8.js
@@ -1887,3 +1887,75 @@ issue_3486_ie8: {
     }
     expect_stdout: "PASS"
 }
+
+issue_3493: {
+    options = {
+        dead_code: true,
+        ie8: false,
+    }
+    input: {
+        var c = "PASS";
+        (function() {
+            try {
+                (function a() {
+                    throw {};
+                })();
+            } catch (a) {
+                a >>= 0;
+                a && (c = "FAIL");
+            }
+        })();
+        console.log(c);
+    }
+    expect: {
+        var c = "PASS";
+        (function() {
+            try {
+                (function a() {
+                    throw {};
+                })();
+            } catch (a) {
+                a >>= 0;
+                a && (c = "FAIL");
+            }
+        })();
+        console.log(c);
+    }
+    expect_stdout: "PASS"
+}
+
+issue_3493_ie8: {
+    options = {
+        dead_code: true,
+        ie8: true,
+    }
+    input: {
+        var c = "PASS";
+        (function() {
+            try {
+                (function a() {
+                    throw {};
+                })();
+            } catch (a) {
+                a >>= 0;
+                a && (c = "FAIL");
+            }
+        })();
+        console.log(c);
+    }
+    expect: {
+        var c = "PASS";
+        (function() {
+            try {
+                (function a() {
+                    throw {};
+                })();
+            } catch (a) {
+                a >>= 0;
+                a && (c = "FAIL");
+            }
+        })();
+        console.log(c);
+    }
+    expect_stdout: "PASS"
+}