From 2273655c17b41ab276172afecd652a297c550c00 Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Tue, 19 Dec 2017 22:19:33 +0800 Subject: [PATCH] fix `inline` after single-use `reduce_vars` (#2623) --- lib/compress.js | 4 ++- test/compress/functions.js | 71 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 74 insertions(+), 1 deletion(-) diff --git a/lib/compress.js b/lib/compress.js index c51a90c13e..c95e4f84b7 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -4004,7 +4004,9 @@ merge(Compressor.prototype, { var catches = Object.create(null); do { scope = compressor.parent(level++); - if (scope instanceof AST_Catch) { + if (scope instanceof AST_SymbolRef) { + scope = scope.fixed_value(); + } else if (scope instanceof AST_Catch) { catches[scope.argname.name] = true; } } while (!(scope instanceof AST_Scope)); diff --git a/test/compress/functions.js b/test/compress/functions.js index 41dfc6a998..bd65a11db3 100644 --- a/test/compress/functions.js +++ b/test/compress/functions.js @@ -1101,3 +1101,74 @@ issue_2616: { } expect_stdout: "PASS" } + +issue_2620_1: { + options = { + inline: true, + reduce_vars: true, + sequences: true, + side_effects: true, + unused: true, + } + input: { + var c = "FAIL"; + (function() { + function f(a) { + var b = function g(a) { + a && a(); + }(); + if (a) { + var d = c = "PASS"; + } + } + f(1); + })(); + console.log(c); + } + expect: { + var c = "FAIL"; + (function() { + (function(a) { + if (function(a) { + a && a(); + }(), a) c = "PASS"; + })(1); + })(), + console.log(c); + } + expect_stdout: "PASS" +} + +issue_2620_2: { + options = { + conditionals: true, + evaluate: true, + inline: true, + passes: 2, + reduce_vars: true, + sequences: true, + side_effects: true, + unused: true, + } + input: { + var c = "FAIL"; + (function() { + function f(a) { + var b = function g(a) { + a && a(); + }(); + if (a) { + var d = c = "PASS"; + } + } + f(1); + })(); + console.log(c); + } + expect: { + var c = "FAIL"; + c = "PASS", + console.log(c); + } + expect_stdout: "PASS" +}