From f412e103106560704f40e4f79795668b7f352ba1 Mon Sep 17 00:00:00 2001
From: Sheetal Nandi <shkamat@microsoft.com>
Date: Tue, 3 Jan 2017 10:59:31 -0800
Subject: [PATCH] Fix the emit when jsx attribute expression is empty Fixes
 #12994

---
 src/compiler/transformers/jsx.ts              |  3 ++
 ...AttributeWithoutExpressionReact.errors.txt | 33 +++++++++++++++++++
 .../jsxAttributeWithoutExpressionReact.js     | 14 ++++++++
 .../jsxAttributeWithoutExpressionReact.tsx    |  9 +++++
 4 files changed, 59 insertions(+)
 create mode 100644 tests/baselines/reference/jsxAttributeWithoutExpressionReact.errors.txt
 create mode 100644 tests/baselines/reference/jsxAttributeWithoutExpressionReact.js
 create mode 100644 tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx

diff --git a/src/compiler/transformers/jsx.ts b/src/compiler/transformers/jsx.ts
index ecb5dd053e084..c0179a10e8853 100644
--- a/src/compiler/transformers/jsx.ts
+++ b/src/compiler/transformers/jsx.ts
@@ -150,6 +150,9 @@ namespace ts {
                 return decoded ? createLiteral(decoded, /*location*/ node) : node;
             }
             else if (node.kind === SyntaxKind.JsxExpression) {
+                if (node.expression === undefined) {
+                    return createLiteral(true);
+                }
                 return visitJsxExpression(<JsxExpression>node);
             }
             else {
diff --git a/tests/baselines/reference/jsxAttributeWithoutExpressionReact.errors.txt b/tests/baselines/reference/jsxAttributeWithoutExpressionReact.errors.txt
new file mode 100644
index 0000000000000..3801562709ac9
--- /dev/null
+++ b/tests/baselines/reference/jsxAttributeWithoutExpressionReact.errors.txt
@@ -0,0 +1,33 @@
+tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx(3,2): error TS2304: Cannot find name 'View'.
+tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx(4,6): error TS2304: Cannot find name 'ListView'.
+tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx(5,10): error TS2304: Cannot find name 'RefreshControl'.
+tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx(5,35): error TS17000: JSX attributes must only be assigned a non-empty 'expression'.
+tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx(6,44): error TS17000: JSX attributes must only be assigned a non-empty 'expression'.
+tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx(7,7): error TS2304: Cannot find name 'ListView'.
+tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx(8,3): error TS2304: Cannot find name 'View'.
+
+
+==== tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx (7 errors) ====
+    
+    declare var React: any;
+    <View>
+     ~~~~
+!!! error TS2304: Cannot find name 'View'.
+        <ListView refreshControl={
+         ~~~~~~~~
+!!! error TS2304: Cannot find name 'ListView'.
+            <RefreshControl onRefresh={} refreshing={} />
+             ~~~~~~~~~~~~~~
+!!! error TS2304: Cannot find name 'RefreshControl'.
+                                      ~~
+!!! error TS17000: JSX attributes must only be assigned a non-empty 'expression'.
+        } dataSource={this.state.ds} renderRow={}>
+                                               ~~
+!!! error TS17000: JSX attributes must only be assigned a non-empty 'expression'.
+        </ListView>
+          ~~~~~~~~
+!!! error TS2304: Cannot find name 'ListView'.
+    </View>
+      ~~~~
+!!! error TS2304: Cannot find name 'View'.
+    
\ No newline at end of file
diff --git a/tests/baselines/reference/jsxAttributeWithoutExpressionReact.js b/tests/baselines/reference/jsxAttributeWithoutExpressionReact.js
new file mode 100644
index 0000000000000..f07cbabd7f812
--- /dev/null
+++ b/tests/baselines/reference/jsxAttributeWithoutExpressionReact.js
@@ -0,0 +1,14 @@
+//// [jsxAttributeWithoutExpressionReact.tsx]
+
+declare var React: any;
+<View>
+    <ListView refreshControl={
+        <RefreshControl onRefresh={} refreshing={} />
+    } dataSource={this.state.ds} renderRow={}>
+    </ListView>
+</View>
+
+
+//// [jsxAttributeWithoutExpressionReact.js]
+React.createElement(View, null,
+    React.createElement(ListView, { refreshControl: React.createElement(RefreshControl, { onRefresh: true, refreshing: true }), dataSource: this.state.ds, renderRow: true }));
diff --git a/tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx b/tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx
new file mode 100644
index 0000000000000..a108a405f9745
--- /dev/null
+++ b/tests/cases/compiler/jsxAttributeWithoutExpressionReact.tsx
@@ -0,0 +1,9 @@
+//@jsx: react
+
+declare var React: any;
+<View>
+    <ListView refreshControl={
+        <RefreshControl onRefresh={} refreshing={} />
+    } dataSource={this.state.ds} renderRow={}>
+    </ListView>
+</View>